fix compact_bundle to enqueue filter compaction for entire range #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for splinterdb canceled.
|
rtjohnso
commented
May 23, 2024
src/trunk.c
Outdated
| @@ -5303,6 +5304,9 @@ trunk_compact_bundle(void *arg, void *scratch_buf) | |||
|
|
|||
| deinit_saved_pivots_in_scratch(scratch); | |||
|
|
|||
| rc = key_buffer_init_from_key(&scratch->req_original_start_key, spl->heap_id, key_buffer_key(&req->start_key)); | |||
There was a problem hiding this comment.
Since we may overwrite the start key of the compaction request, save it here.
src/trunk.c
Outdated
| @@ -5445,8 +5450,10 @@ trunk_compact_bundle(void *arg, void *scratch_buf) | |||
| key_string(trunk_data_config(spl), end_key), | |||
| req->height, | |||
| req->bundle_no); | |||
| key_buffer_copy_key(&req->start_key, key_buffer_key(&scratch->req_original_start_key)); | |||
There was a problem hiding this comment.
Restore it here so that the filter compaction will cover the entire range of the original bundle compaction request,
ajhconway
suggested changes
May 27, 2024
| @@ -5445,8 +5453,11 @@ trunk_compact_bundle(void *arg, void *scratch_buf) | |||
| key_string(trunk_data_config(spl), end_key), | |||
| req->height, | |||
| req->bundle_no); | |||
| key_buffer_copy_key(&req->start_key, | |||
There was a problem hiding this comment.
There's a sort of smoke and mirrors thing happening here, where start_key is the start key of each split-sibling node during the compaction cleanup, but then it gets reset as the filter start key here.
I think it would be better if the compaction cleanup start key was its own variable, preferably not attached to req.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.