[Origin API] Add more test coverage for opaque origin comparison #56922
+76
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
7b9fa1b to
fdd7cd3
Compare
shannonbooth
commented
Dec 24, 2025
| const worker = new Worker(dataURL); | ||
| worker.onmessage = e => { | ||
| assert_true(e.data.isOpaque, "Origin created from data URL Worker should be an opaque origin."); | ||
| assert_false(e.data.sameOrigin, "Two data URL opaque origins should not be same-origin with one another."); |
Contributor
Author
There was a problem hiding this comment.
My original interpretation of https://html.spec.whatwg.org/multipage/workers.html#set-up-a-worker-environment-settings-object of returning a new opaque origin every time doesn't seem right, based on test results maybe I should make a MR to the HTML spec to change it to be more like the Worklet case which stores origin as a variable instead of creating a new one each time.
fdd7cd3 to
2efdaa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mikewest @annevk
Relating to whatwg/url#892
One case which I didn't figure out a nice way of covering is opaque origin Worker which is not a data scheme URL