Skip to content

Rename Tool#window to Tool#source #385

Open

Description

@domfarolino

This is to future-proof us for when we eventually integrate with workers, the source of a tool may not be a window object, but instead might be a window or other worker-related proxy objects. Renaming the Tool interface's window member to source more closely matches MessageEvent#source.

/cc @khushalsagar @jakearchibald @beaufortfrancois

Activity

  1. self-assigned this
    on Nov 12, 2026
  2. beaufortfrancois commented on Nov 18, 2026

    @beaufortfrancois
    Collaborator

    @domfarolino I can go ahead and open a spec PR for this now if that's okay with you.
    I think having this defined in the spec sooner rather than later is ideal, regardless of when the Tool interface PR lands.

    FYI, I've already started working on a Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/8832638

  3. domfarolino commented on Nov 18, 2026

    @domfarolino
    CollaboratorAuthor

    I'll take this no worries. It's already assigned to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions