-
-
Notifications
You must be signed in to change notification settings - Fork 64
feat(examples): overloads #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 42346ad The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Wip
FeaturesCode Refactoring
ChoreTests
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -2.63 kB (-6%) ✅ Total Size: 44.2 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 99.87% 99.87% -0.01%
==========================================
Files 17 17
Lines 1632 1614 -18
Branches 276 276
==========================================
- Hits 1630 1612 -18
Misses 2 2
|
Co-authored-by: 0xRaiden <[email protected]>
Description
Adds support for overload narrowing in examples. For example, supposed I have the following ABI:
Function
foohas multiple overloads. Previously, callingreadwithfoowould return a union for the return type:This PR adds logic to narrow the return type further based on
argsso it only returns the result for the matched overload:TODO
Additional Information
Your ENS/address: awkweb.eth
PR-Codex overview
This PR removes internal barrel exports, reorganizes some imports, and improves type definitions.
Detailed summary