new inspect that outputs ruby code #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -211,7 +211,33 @@ def to_sexp(indent=0) | |||
|
|
|||
| sexp | |||
| end | |||
| alias :inspect :to_sexp | |||
There was a problem hiding this comment.
This should become alias :to_s :to_sexp.
There was a problem hiding this comment.
to_s is defined, so i did't want to touch that
figured you can easily do that line if you want it. That change hasn't really got anything to do with the inspect changing.
|
By the way, you don't have to recreate pull requests. Any commits you add or replace in your branch will be picked up by GitHub. |
|
btw, thanks, i did know. But i had changed the tests beyond recognition, so it was easier to start fresh |
|
Merged in 84da266. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok second try. to_sexp as was and new inspect.
sorry for misunderstanding before