Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER]: cmake installs files into non-standard loctations #810

Closed
yurivict opened this issue Dec 6, 2024 · 2 comments
Closed

[OTHER]: cmake installs files into non-standard loctations #810

yurivict opened this issue Dec 6, 2024 · 2 comments

Comments

@yurivict
Copy link

yurivict commented Dec 6, 2024

Please don't use.

Particularly, the src directory is installed right into $PREFIX.

I suggest that you should move it to share/nanobind/src.

The files __init__.py and __init__.py don't appear to be needed.

$PREFIX/stubgen.py should be moved to $PREFIX/share/nanobind/stubgen.py.

Otherwise all packagers would have problems with the nanobind C++ port.

@wjakob
Copy link
Owner

wjakob commented Dec 10, 2024

Note: please don't use this ticket template (it is called "Please don't use"..).

The __init__.py file is most certainly needed. The nanobind CMake build system's install targets exist to facilitate building the PyPI packages through scikit-build-core, which is the official distribution mechanism. It is not designed to do what you are trying to do with it (which I think is to somehow make it compatible with the FreeBSD ports system). Generally, FreeBSD is not a supported platform, and custom changes needed to integrate them there should be shipped/patched via ports instead of trying to get them merged here.

The exchanges with you frustrate me because you don't seem to know this project all that well, and yet you regularly open haphazardly written tickets that waste time.

Sorry, but if this continues, I will need to block you from this project.

@wjakob wjakob closed this as completed Dec 10, 2024
@yurivict
Copy link
Author

Ok, I will delete the FreeBSD ports for nanobind then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants