Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: A Bazel branch for nanobind_bazel tests #40

Closed
nicholasjng opened this issue Feb 20, 2024 · 3 comments
Closed

Request: A Bazel branch for nanobind_bazel tests #40

nicholasjng opened this issue Feb 20, 2024 · 3 comments

Comments

@nicholasjng
Copy link
Collaborator

I'm currently trying to set up CI for nanobind_bazel, and I want to use this example as a build test.

Would it be OK for you to push a with-bazel branch (or similar) that contains the setup for a nanobind_bazel build of this example, which I can then use in actions/checkout? (If not, I can also fork of course.)

@wjakob
Copy link
Owner

wjakob commented Feb 20, 2024

Certainly. I will add you as a committer, feel free to make branches as you please.

@wjakob
Copy link
Owner

wjakob commented Feb 20, 2024

Naming-wise, I think I have a preference for just bazel instead of with-bazel.

@nicholasjng
Copy link
Collaborator Author

The bazel branch is pushed, first tests have passed (but not all of them, ABI mismatches). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants