Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the wheels.yml example still considered a good template? #57

Open
alecjacobson opened this issue Dec 9, 2024 · 2 comments
Open

Is the wheels.yml example still considered a good template? #57

alecjacobson opened this issue Dec 9, 2024 · 2 comments

Comments

@alecjacobson
Copy link

Is the https://github.com/wjakob/nanobind_example/blob/master/.github/workflows/wheels.yml still considered a good template to build off of for nanobind projects?
I immediately hit a bunch of different issues on all three platforms, before I get too deep debugging I'd like to know if this was indeed the right starting point or if there's a better example out there.
Thank you!

@wjakob
Copy link
Owner

wjakob commented Dec 9, 2024

This should be okay. What were the issues?

@alecjacobson
Copy link
Author

Thanks for confirming. I think most of the issues were my confusion about what params belong in the pyproject.toml and what belongs in the wheels.yml.

Perhaps one thing that could be noted in the documentation of this example (it's probably somewhere in the nanobind docs) is that the src/nanobind_example/__init__.py file is essential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants