Assume sourcemap name if blank

[pgross41]

I was using this successfully on webpack 3 but it fails after upgrading to webpack 5 with the following error, written multiple times:

⬡ ElasticAPMSourceMapPlugin: there is no .js files to be uploaded.

I determined the sourceFile was populated but the sourceMap was blank. I'm sure there is a correct way to do this with webpack 5 but this is a nice cheap solution. 🙂

[codecov-commenter]

Codecov Report

Merging #674 (7f213c7) into master (92e5d02) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files           1        1           
  Lines          29       29           
  Branches        4        4           
=======================================
  Hits           28       28           
  Partials        1        1           

Impacted Files	Coverage Δ
src/elastic-apm-sourcemap-webpack-plugin.ts	96.55% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e5d02...7f213c7. Read the comment docs.

[pgross41]

@wuct please review

[wuct]

@pgross41 the current code assume js source map files have file extentions .js.map here. You can control how webpack generates the filename of source map by configuring output.sourceMapFilename. However, I think it is useful that ElasticAPMSourceMapPlugin can provide a config to enable sourcemap filename customization. I will happy to accept a diff for it. :)

[pgross41]

@wuct my files are using .js.map but the sourceMap param is undefined. Added a breakpoint to the location you indicated. it looks like in webpack 5 the sourcemap files aren't in files they are in auxiliaryFiles

Would you prefer something like this over the code that is currently in the PR?

const allFiles = [...files, ...auxiliaryFiles];
const sourceFile = R.find(R.test(/\.js$/), allFiles);
const sourceMap = R.find(R.test(/\.js\.map$/), allFiles);

[wuct]

@pgross41 ah, it makes sense to me! Do you mind to also update the webpack version here to 5 and check the integration test passed?

[pgross41]

@wuct I updated webpack to 5 but the integration test errors here with:

TypeError: Cannot read property 'source' of undefined

This expression is undefined:

compilation.assets[sourceMap]

I have tried tweaking it but don't even know what to change to get the file contents of the sourcemap. I also tried the allFiles idea above but auxiliaryFiles is empty. I can't figure out what is different about my build, it seems like my sourcemaps are coming from the TerserPlugin so I tried adding that but it had the same errors.

So it looks like this PR won't add any broad support for webpack 5 but it does add support for the particular webpack 5 config for our project 🙂

[wuct]

@pgross41 I've fixed the test in Webpack 5 in this branch. I also fixed the sourcemap finding issue in that branch. Could you help me test it? I am not using ElasticAPM recently. Thanks a lot!

[pgross41]

@wuct thanks for properly fixing my bandaid solution. I pulled the webpack5 branch, ran npm run build:js and plopped the js file into my project. It worked!

[pgross41]

@wuct is your webpack5 branch ready for a release?

[wuct]

@wuct is your webpack5 branch ready for a release?

Yes, I'll release it this week. Just too busy these days, sorry about that.

[pgross41]

No problem, I totally understand and I appreciate your time!

[pgross41]

Thank you @wuct!

[wuct]

@pgross41 you are very welcome! Thanks for bringing it up!