Skip to content

feat: add select-all toggle in Agent Builder & fix tool access control#215

Open
yiboyasss wants to merge 2 commits intoxorbitsai:mainfrom
yiboyasss:feat/agent-builder-select-all
Open

feat: add select-all toggle in Agent Builder & fix tool access control#215
yiboyasss wants to merge 2 commits intoxorbitsai:mainfrom
yiboyasss:feat/agent-builder-select-all

Conversation

@yiboyasss
Copy link
Contributor

  1. Features (Frontend)

    • Added a Select All toggle in the Knowledge Base, Skills, and Tools configuration sections of the Agent Builder.
    • Implemented automatic state synchronization between the Select All toggle and the MultiSelect component (selecting all options enables Select All, and vice versa).
  2. Bug Fixes (Backend)

    • Fixed an issue where the Agent could still access knowledge bases/tools even when none were selected.
    • Improved permission control logic by replacing implicit boolean checks with explicit is not None checks, clearly distinguishing between None (default: full access) and [] (no selection: access denied).
    • Fixed incorrect initialization of allowed_tools as None instead of [] in websocket.py and chat.py.

- Change  initialization from  to  in websocket and chat APIs to prevent unfiltered tool access.
- Update  check to explicitly verify  to distinguish between intentional empty selection and default full access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants