Fix ^C not working to end for newer fish + kitty keyboard protocol#5737
Merged
anthonykim1 merged 1 commit intomasterfrom Mar 6, 2026
Merged
Fix ^C not working to end for newer fish + kitty keyboard protocol#5737anthonykim1 merged 1 commit intomasterfrom
anthonykim1 merged 1 commit intomasterfrom
Conversation
This was referenced Mar 6, 2026
Br1an67
pushed a commit
to Br1an67/xterm.js
that referenced
this pull request
Mar 7, 2026
…oardFish Fix ^C not working to end for newer fish + kitty keyboard protocol
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve: microsoft/vscode#295372
We shouldn't read beyond params.length - 1:
xterm.js/src/common/parser/Params.ts
Line 19 in a12061c
Reset only sets this.length = 0, it does not zero out underlying array.
So when fish sends CSI = 0 u (one param), params.length is 1, but params.params[1] reads whatever int was left in slot 1 from previous CSI sequence.
SO if that leftover vlaue happens to be 2 or 3,
modebecomes 2,3 instead of spec-mandated default 1: