Open
Conversation
Member
|
@fkohlgrueber thanks! I think it should stay as an absolute path, though. I don't think that serving from a path other than How about we add a note in the README explaining to devs that fall into your camp that they need to use a relative path? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes two paths from absolute to relative. This fixed 404s when serving the app from a route other than
/. With these changes, the app can be deployed to github pages for example with wasn't working before (e.g. see this repo; rendered).As far as I can see, this doesn't break any existing cases.