Skip to content

feat: add support for JSON type #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larkee merged 22 commits into from
Aug 26, 2021
Merged

feat: add support for JSON type #353

larkee merged 22 commits into from
Aug 26, 2021

Conversation

@asthamohta
Copy link
Contributor

@asthamohta asthamohta commented May 19, 2021

feat: add support for JSON type

@asthamohta asthamohta requested a review from a team as a code owner May 19, 2021 12:17
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label May 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2021
@asthamohta asthamohta requested review from larkee, vi3k6i5 and zoercai May 19, 2021 12:18
@larkee larkee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2021
zoercai
zoercai approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@zoercai zoercai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for functionality in general and test examples, I'll leave the implementation/Python review to @larkee

larkee
larkee approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@parthea parthea mentioned this pull request Jul 3, 2021
Merged
@skuruppu
Copy link
Contributor

skuruppu commented Jul 5, 2021

@asthamohta we merged the code generation PR, so you should now be able to rebase and hopefully get rid of the generated code from the PR.

@zoercai zoercai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@zoercai zoercai removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 23, 2021
@zoercai zoercai added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@asthamohta asthamohta added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 24, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021
@zoercai zoercai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@larkee larkee merged commit b1dd04d into googleapis:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larkee larkee larkee approved these changes

@vi3k6i5 vi3k6i5 Awaiting requested review from vi3k6i5

+1 more reviewer

@zoercai zoercai zoercai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asthamohta @skuruppu @zoercai @larkee @yoshi-kokoro