Conversation
|
Thanks a lot for the pull request @marcingrzejszczak !
This is the way CXF structures the integrations: the tracing is separated from metrics (integration/tracing). Could you please split them into separate modules? Thank you. |
411a850 to
fea1273
Compare
|
@reta I've moved the Micrometer Observation integration under the tracing folder. The integration allows you to actually not have tracing at all and in essence is tracing agnostic, however for the sake of consistency I put it under the tracing folder |
Thanks a lot @marcingrzejszczak , there are some failures in the build, could you please take a look? thank you |
...src/test/java/org/apache/cxf/systest/jaxrs/spring/boot/SpringJaxrsComponentScanningTest.java
Outdated
Show resolved
Hide resolved
.../apache/cxf/spring/boot/autoconfigure/micrometer/MicrometerObservationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
… we have http spans present
even though Micrometer Observation gives you more features than tracing we moved it under the tracing folder to other integrations
aef765e to
5ebe22b
Compare
|
Hey @reta . I've applied all the suggestions and rebased the branch against |
...boot/src/test/java/org/apache/cxf/systest/jaxrs/spring/boot/SpringJaxrsObservabiityTest.java
Outdated
Show resolved
Hide resolved
...boot/src/test/java/org/apache/cxf/systest/jaxrs/spring/boot/SpringJaxrsObservabiityTest.java
Show resolved
Hide resolved
...boot/src/test/java/org/apache/cxf/systest/jaxrs/spring/boot/SpringJaxrsObservabiityTest.java
Show resolved
Hide resolved
...boot/src/test/java/org/apache/cxf/systest/jaxrs/spring/boot/SpringJaxrsObservabiityTest.java
Show resolved
Hide resolved
...boot/src/test/java/org/apache/cxf/systest/jaxrs/spring/boot/SpringJaxrsObservabiityTest.java
Outdated
Show resolved
Hide resolved
|
LGTM! |
This PR adds support for Micrometer Observation instrumentation of Apache CXF.
NOTE: This PR is heavily influenced by Brave's implementation.
Dependencies
CXF metrics project
rt-managementsince metrics will now also be related to tracingObservationDocumentationthat using https://micrometer.io/docs/observation#_documentation_generation could generate asciidoctor documentation of observability dataSpring Boot
MicrometerObservationAutoConfigurationthat registersFeatures as beansTests
TODO ? :
Screenshots from Zipkin:
Fixes https://issues.apache.org/jira/browse/CXF-8817