small memory improvement : do dot convert all the url to check the prefix#228
Closed
benbenw wants to merge 1 commit intoapache:trunkfrom
benbenw:small-perf
Closed
small memory improvement : do dot convert all the url to check the prefix#228benbenw wants to merge 1 commit intoapache:trunkfrom benbenw:small-perf
benbenw wants to merge 1 commit intoapache:trunkfrom
benbenw:small-perf
Conversation
Collaborator
|
Looks good. Just one question: HOW did you find that? |
Contributor
|
It may be slightly more efficient to use regionMatches, but it's not nearly so obvious what the code is doing. However checking log.isDebugEnabled() first is an improvement. |
Contributor
|
There is StringUtils#startsWithIgnoreCase, that does the same and is clearly named. |
asfgit
pushed a commit
that referenced
this pull request
Sep 8, 2016
git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1759866 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prefix