Skip to content

small memory improvement : do dot convert all the url to check the prefix #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benbenw wants to merge 1 commit into from
Closed

small memory improvement : do dot convert all the url to check the prefix #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,8 @@ public static String[] getSourceTypeList() {

private static final String RESPONSE_PARSERS = // list of parsers
JMeterUtils.getProperty("HTTPResponse.parsers");//$NON-NLS-1$

private static final String LOCAL_FILE_PREFIX = "file:"; // $NON-NLS-1$

static {
String[] parsers = JOrphanUtils.split(RESPONSE_PARSERS, " " , true);// returns empty array for null
Expand Down Expand Up @@ -1363,12 +1365,13 @@ private LinkExtractorParser getParser(HTTPSampleResult res)
* @return escaped url
*/
private String escapeIllegalURLCharacters(String url) {
if (url == null || url.toLowerCase().startsWith("file:")) {
if (url == null || url.regionMatches(true, 0, LOCAL_FILE_PREFIX, 0, LOCAL_FILE_PREFIX.length())) {
return url;
}

try {
String escapedUrl = ConversionUtils.escapeIllegalURLCharacters(url);
if (!escapedUrl.equals(url) && log.isDebugEnabled()) {
if (log.isDebugEnabled() && !escapedUrl.equals(url)) {
log.debug("Url '" + url + "' has been escaped to '"
+ escapedUrl + "'. Please correct your webpage.");
}
Expand Down