Switch from 'toml' package to tomli/tomllib#72
Merged
arkq merged 2 commits intoarkq:masterfrom Jan 12, 2023
Merged
Conversation
Python 3.11 comes with built-in support for TOML. It's an almost direct import of the tomli package. As the 'toml' library is unmaintained, and tomli has the same interface as what's in the standard library, this switches the TOML support to a supported library with a minimum of fuss. Tomllib requires files to be opened in 'rb' mode, so the relevant tests had to be updated accordingly.
Contributor
Author
|
@arkq I've updated the PR to resolve the issues with the first build 👍 |
Codecov ReportBase: 93.63% // Head: 93.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 93.63% 93.43% -0.21%
==========================================
Files 3 3
Lines 393 396 +3
==========================================
+ Hits 368 370 +2
- Misses 25 26 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.11 comes with built-in support for TOML. It's an almost direct import of the tomli package. As the 'toml' library is unmaintained, and tomli has the same interface as what's in the standard library, this switches the TOML support to a supported library with a minimum of fuss.
Tomllib requires files to be opened in 'rb' mode, so the relevant tests had to be updated accordingly.
Fixes #70