Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version in release workflow #633

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 18, 2024

Summary

This PR updates the minimum Node version to 22 and is a follow-up from #631. The dependencies that we use to publish the build artifacts bumped the minimum version of Node to 20. I've bumped it to 22 as that's the minimum active LTS version right now.

Along with the node version bump, this PR also updates the said dependencies (ovsx and vsce) to the latest version which requires a minimum node version of 20.

Test Plan

When I perform the next release :)

@MichaReiser
Copy link
Member

We could consider testing this together with upgrading the release dependencies

@dhruvmanila
Copy link
Member Author

We could consider testing this together with upgrading the release dependencies

Yeah, makes sense.

@MichaReiser
Copy link
Member

Note. I think the marketplace have a --dry-run flag or similar that we could use to test the change without publishing.

@dhruvmanila
Copy link
Member Author

Note. I think the marketplace have a --dry-run flag or similar that we could use to test the change without publishing.

Hmm, I don't see a --dry-run or related flag in the vsce / ovsx tools that we use to publish.

@MichaReiser
Copy link
Member

I guess you could try --skip-duplicate but feels risky. I'm also up to just merge and revert if we run into problems during the next release.

@dhruvmanila
Copy link
Member Author

I guess you could try --skip-duplicate but feels risky. I'm also up to just merge and revert if we run into problems during the next release.

Yeah, that does seem risky. Another option would be to create a dummy account and do the release there but I think I'd just prefer to merge it and make a mental note to verify when doing the release.

@dhruvmanila dhruvmanila marked this pull request as ready for review October 22, 2024 12:11
@dhruvmanila dhruvmanila merged commit 4687dff into main Oct 22, 2024
6 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/update-node branch October 22, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants