Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-logging] Implement LOG007: ExceptionWithoutExcInfo #7410

Merged
merged 9 commits into from
Sep 18, 2023
Merged

[flake8-logging] Implement LOG007: ExceptionWithoutExcInfo #7410

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3743f1c
Add LOG009 and flake8_logging boilerplate
qdegraaf Sep 8, 2023
dc1bacb
Add `ExcInfoFalseInException` Violation
qdegraaf Sep 8, 2023
d42e6d6
Make test fixture more compact, clippy, regen snapshots
qdegraaf Sep 15, 2023
b610037
Fix doc, add testcases for logger.exception()
qdegraaf Sep 18, 2023
662e9c1
Also flag `logger.exception()` calls
qdegraaf Sep 18, 2023
b03e733
Remove explicit Expr::Atrribute check
qdegraaf Sep 18, 2023
b7cd0c6
Merge branch 'main' into rule/LOG007
charliermarsh Sep 18, 2023
c99cdca
Doc tweaks
charliermarsh Sep 18, 2023
ed1190f
Rename
charliermarsh Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add LOG009 and flake8_logging boilerplate
  • Loading branch information
@qdegraaf
qdegraaf committed Sep 18, 2023
commit 3743f1c13f9ec7e419f3c14917ea653eb04b7e22
3 changes: 3 additions & 0 deletions crates/ruff/src/codes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,6 +925,9 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
(Flake8Logging, "002") => (RuleGroup::Preview, rules::flake8_logging::rules::InvalidGetLoggerArgument),
(Flake8Logging, "009") => (RuleGroup::Preview, rules::flake8_logging::rules::UndocumentedWarn),

// flake8-logging
(Flake8Logging, "009") => (RuleGroup::Nursery, rules::flake8_logging::rules::UndocumentedWarn),

_ => return None,
})
}