Add ExcInfoFalseInException Violation

crates/ruff/resources/test/fixtures/flake8_logging/LOG007.py

@@ -0,0 +1,17 @@
+import logging
+from logging import exception
+
+
+logging.exception("foo")  # OK
+
+
+logging.exception("foo", exc_info=False)  # LOG007
+
+
+logging.exception("foo", exc_info=[])  # LOG007
+
+
+exception("foo", exc_info=False)  # LOG007
+
+
+logging.exception("foo", exc_info=True)  # OK

crates/ruff/src/checkers/ast/analyze/expression.rs

@@ -898,6 +898,9 @@ pub(crate) fn expression(expr: &Expr, checker: &mut Checker) {
             if checker.enabled(Rule::InvalidGetLoggerArgument) {
                 flake8_logging::rules::invalid_get_logger_argument(checker, call);
             }
+            if checker.enabled(Rule::ExcInfoFalseInException) {
+                flake8_logging::rules::exc_info_false_in_exception(checker, call);
+            }
         }
         Expr::Dict(ast::ExprDict {
             keys,

crates/ruff/src/codes.rs

@@ -926,6 +926,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Flake8Logging, "009") => (RuleGroup::Preview, rules::flake8_logging::rules::UndocumentedWarn),
 
         // flake8-logging
+        (Flake8Logging, "007") => (RuleGroup::Nursery, rules::flake8_logging::rules::ExcInfoFalseInException),
         (Flake8Logging, "009") => (RuleGroup::Nursery, rules::flake8_logging::rules::UndocumentedWarn),
 
         _ => return None,

crates/ruff/src/rules/flake8_logging/mod.rs

@@ -15,6 +15,7 @@ mod tests {
 
     #[test_case(Rule::DirectLoggerInstantiation, Path::new("LOG001.py"))]
     #[test_case(Rule::InvalidGetLoggerArgument, Path::new("LOG002.py"))]
+    #[test_case(Rule::ExcInfoFalseInException, Path::new("LOG007.py"))]
     #[test_case(Rule::UndocumentedWarn, Path::new("LOG009.py"))]
     fn rules(rule_code: Rule, path: &Path) -> Result<()> {
         let snapshot = format!("{}_{}", rule_code.noqa_code(), path.to_string_lossy());

crates/ruff/src/rules/flake8_logging/rules/exc_info_false_in_exception.rs

@@ -0,0 +1,54 @@
+use ruff_python_ast::ExprCall;
+
+use ruff_diagnostics::{Diagnostic, Violation};
+use ruff_macros::{derive_message_formats, violation};
+use ruff_python_ast::helpers::Truthiness;
+use ruff_text_size::Ranged;
+
+use crate::checkers::ast::Checker;
+
+/// ## What it does
+/// Checks for uses of `logging.exception()` with `exc_info` set to `False`
+///
+/// ## Why is this bad?
+/// The `exception()` method captures the exception automatically. Disabling this by setting
+/// `exc_info=False` is the same as using `error()`, which is clearer and doesn’t need the
+/// `exc_info`argument. This rule detects `exception()` calls with an exc_info argument that is
+/// falsy.
+/// 
+/// ## Example
+/// ```python
+/// logging.exception("foo", exc_info=False)
+/// ```
+///
+/// Use instead:
+/// ```python
+/// logging.error("foo")
+/// ```
+#[violation]
+pub struct ExcInfoFalseInException;
+
+impl Violation for ExcInfoFalseInException {
+    #[derive_message_formats]
+    fn message(&self) -> String {
+        format!("Use of `logging.exception` with falsy `exc_info`")
+    }
+}
+
+/// LOG007
+pub(crate) fn exc_info_false_in_exception(checker: &mut Checker, call: &ExprCall) {
+    if checker
+        .semantic()
+        .resolve_call_path(call.func.as_ref())
+        .is_some_and(|call_path| matches!(call_path.as_slice(), ["logging", "exception"]))
+    {
+        if let Some(_) = call.arguments.find_keyword("exc_info").filter(|keyword| {
+            Truthiness::from_expr(&keyword.value, |id| checker.semantic().is_builtin(id))
+                .is_falsey()
+        }) {
+            checker
+                .diagnostics
+                .push(Diagnostic::new(ExcInfoFalseInException, call.range()));
+        }
+    }
+}

crates/ruff/src/rules/flake8_logging/rules/mod.rs

@@ -1,7 +1,9 @@
 pub(crate) use direct_logger_instantiation::*;
+pub(crate) use exc_info_false_in_exception::*;
 pub(crate) use invalid_get_logger_argument::*;
 pub(crate) use undocumented_warn::*;
 
 mod direct_logger_instantiation;
+mod exc_info_false_in_exception;
 mod invalid_get_logger_argument;
 mod undocumented_warn;

crates/ruff/src/rules/flake8_logging/snapshots/ruff__rules__flake8_logging__tests__LOG007_LOG007.py.snap

@@ -0,0 +1,22 @@
+---
+source: crates/ruff/src/rules/flake8_logging/mod.rs
+---
+LOG007.py:8:1: LOG007 Use of `logging.exception` with falsy `exc_info`
+  |
+8 | logging.exception("foo", exc_info=False)  # LOG007
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ LOG007
+  |
+
+LOG007.py:11:1: LOG007 Use of `logging.exception` with falsy `exc_info`
+   |
+11 | logging.exception("foo", exc_info=[])  # LOG007
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ LOG007
+   |
+
+LOG007.py:14:1: LOG007 Use of `logging.exception` with falsy `exc_info`
+   |
+14 | exception("foo", exc_info=False)  # LOG007
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ LOG007
+   |
+
+