Skip to content

Rename gcs.NewGCSArtifactService to gcsartifact.NewService #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rakyll merged 1 commit into from
Nov 13, 2025
Merged

Rename gcs.NewGCSArtifactService to gcsartifact.NewService #271

rakyll merged 1 commit into from
Nov 13, 2025

Conversation

@rakyll
Copy link
Member

@rakyll rakyll commented Nov 13, 2025 •
edited
Loading

  • Per Go style guideline, avoid repetitiveness caused by package name in identifier names.
  • Rename gcs package to gcsartifact to differentiate it from the official GCS client package in Go.

@rakyll rakyll requested a review from dpasiukevich November 13, 2025 04:19
@rakyll rakyll marked this pull request as ready for review November 13, 2025 04:19
@rakyll
Rename gcs.NewGCSArtifactService to gcs.NewArtifactsService
a4131de 
Per Go style guideline, avoid repetitiveness caused by package name in identifier names.
@rakyll rakyll changed the title Rename gcs.NewGCSArtifactService to gcs.NewArtifactsService Rename gcs.NewGCSArtifactService to gcsartifact.NewService Nov 13, 2025
@rakyll rakyll merged commit b5bc2c3 into main Nov 13, 2025
3 checks passed
@rakyll rakyll deleted the gcs branch November 13, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpasiukevich dpasiukevich dpasiukevich approved these changes

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rakyll @dpasiukevich