Skip to content

Rename gcs.NewGCSArtifactService to gcsartifact.NewService #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakyll merged 1 commit into from
Nov 13, 2025
Merged

Rename gcs.NewGCSArtifactService to gcsartifact.NewService #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 artifact/gcs/gcs_client.go → artifact/gcsartifact/gcs_client.go
View file
Open in desktop
File renamed without changes.
0 artifact/gcs/gcs_test.go → artifact/gcsartifact/gcs_test.go
View file
Open in desktop
File renamed without changes.
6 changes: 2 additions & 4 deletions artifact/gcs/service.go → artifact/gcsartifact/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,19 @@ type gcsService struct {
bucket gcsBucket
}

// NewGCSArtifactService creates a gcsService for the specified bucket using a default client
func NewGCSArtifactService(ctx context.Context, bucketName string, opts ...option.ClientOption) (artifact.Service, error) {
// NewService creates a Google Cloud Storage service for the specified bucket.
func NewService(ctx context.Context, bucketName string, opts ...option.ClientOption) (artifact.Service, error) {
storageClient, err := storage.NewClient(ctx, opts...)
if err != nil {
return nil, fmt.Errorf("failed to create gcs service: %w", err)
}
// Wrap the real client
clientWrapper := &gcsClientWrapper{client: storageClient}

s := &gcsService{
bucketName: bucketName,
storageClient: clientWrapper,
bucket: clientWrapper.bucket(bucketName),
}

return s, nil
}

Expand Down