-
Notifications
You must be signed in to change notification settings - Fork 33
feat: drop read_only on a connection returned back to a pool #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
commented
Jan 10, 2022
vi3k6i5
approved these changes
Jan 28, 2022
Contributor
vi3k6i5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/python-spanner-sqlalchemy API.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current connections reset mechanism doesn't drop
read_onlyproperty of a connection returned back to a connections pool. It makes the following cases possible:ReadOnlyconnection, executes some operations and returnes the connection back to the pool (automatically)ReadOnly, but the pool returns the connection, which was toggled to theReadOnlymode earlier (as it's a pool, it returns the connections created earlier, it is its purpos).Such a situation can be very unexpected and will require for user to write additional logic to understand if the connection can be used in their case. To avoid it, we better drop
read_onlyattribute to its default value when a connection is returned back to pool.P.S. because of the same reasons we're already dropping
stalenessattribute on a connection reset.