Skip to content

okhttp: add max connection idle at OkHttpServerBuilder#9494

Merged
YifeiZhuang merged 4 commits intogrpc:masterfrom
YifeiZhuang:okhttp-idle-manager
Aug 29, 2022
Merged

okhttp: add max connection idle at OkHttpServerBuilder#9494
YifeiZhuang merged 4 commits intogrpc:masterfrom
YifeiZhuang:okhttp-idle-manager

Conversation

@YifeiZhuang
Copy link
Member

No description provided.

@YifeiZhuang YifeiZhuang requested a review from ejona86 August 26, 2022 19:34
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

respondWithHttpError() also needs the active check.

@YifeiZhuang YifeiZhuang requested a review from ejona86 August 29, 2022 20:42
@YifeiZhuang YifeiZhuang enabled auto-merge (squash) August 29, 2022 23:25
@YifeiZhuang YifeiZhuang merged commit 7291ad4 into grpc:master Aug 29, 2022
@YifeiZhuang YifeiZhuang deleted the okhttp-idle-manager branch August 29, 2022 23:29
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Sep 7, 2022
YifeiZhuang added a commit that referenced this pull request Sep 8, 2022
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Sep 9, 2022
YifeiZhuang added a commit that referenced this pull request Sep 9, 2022
* Revert "Revert "okhttp: add max connection idle at OkHttpServer (#9494)" (#9528)"

This reverts commit 95b9d6d and fixed flaky test.
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
* Revert "Revert "okhttp: add max connection idle at OkHttpServer (grpc#9494)" (grpc#9528)"

This reverts commit 95b9d6d and fixed flaky test.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants