Skip to content

Revert "okhttp: add max connection idle at OkHttpServer (#9494)"#9528

Merged
YifeiZhuang merged 1 commit intogrpc:masterfrom
YifeiZhuang:okhttp-keepalivepermit
Sep 8, 2022
Merged

Revert "okhttp: add max connection idle at OkHttpServer (#9494)"#9528
YifeiZhuang merged 1 commit intogrpc:masterfrom
YifeiZhuang:okhttp-keepalivepermit

Conversation

@YifeiZhuang
Copy link
Member

This reverts commit 7291ad4.

@YifeiZhuang YifeiZhuang requested a review from ejona86 September 7, 2022 23:22
@YifeiZhuang YifeiZhuang enabled auto-merge (squash) September 8, 2022 14:29
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for revert?

@YifeiZhuang YifeiZhuang merged commit 95b9d6d into grpc:master Sep 8, 2022
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Sep 9, 2022
YifeiZhuang added a commit that referenced this pull request Sep 9, 2022
* Revert "Revert "okhttp: add max connection idle at OkHttpServer (#9494)" (#9528)"

This reverts commit 95b9d6d and fixed flaky test.
@YifeiZhuang YifeiZhuang deleted the okhttp-keepalivepermit branch September 12, 2022 17:39
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
* Revert "Revert "okhttp: add max connection idle at OkHttpServer (grpc#9494)" (grpc#9528)"

This reverts commit 95b9d6d and fixed flaky test.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants