Skip to content

Conversation

@ethercrow
Copy link
Contributor

Example run: https://github.com/ethercrow/bytestring/actions/runs/326555407

It actually shows that there are some issues on Windows, presumably not in the library but in the test suite.

@Bodigrim
Copy link
Contributor

Thanks! I do not have a Windows machine at the moment, will take a look at failing tests next week.

I wonder if #312, which removes unsafePerformIO from tests, could be relevant.

@Bodigrim
Copy link
Contributor

This is getting interesting: Windows tests work fine for GHC 8.8, but fail for GHC 8.10.

Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I can reproduce Windows failures locally, they are genuine issues (presumably with the test suite rather than with the library), and PR itself is good to be merged. Thanks!

@Bodigrim Bodigrim requested a review from sjakobi October 29, 2020 18:23
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a minor suggestion.

Comment on lines 36 to 52
- name: Build
run: |
cabal build all
- name: Test
run: |
cd tests && cabal test
- name: SDist
run: |
cabal sdist all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about including haddocks, and particularly benchmarks? See

bytestring/.travis.yml

Lines 51 to 54 in 1f97c4c

# Build the benchmarks and run a single iteration.
- if [ "$GHCNUMVER" -ge 71000 ]; then
(cd bench; cabal v2-bench -O0 --benchmark-options "--quick --min-duration=0 --include-first-iter");
fi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethercrow ethercrow force-pushed the master branch 2 times, most recently from dbd4f95 to 92a4cf9 Compare October 29, 2020 20:38
@ethercrow ethercrow marked this pull request as draft October 29, 2020 20:39
@ethercrow ethercrow marked this pull request as ready for review October 29, 2020 21:37
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more minor suggestion. Thanks!

@ethercrow
Copy link
Contributor Author

Gentle tactical bump.

Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bodigrim Bodigrim merged commit 8af9778 into haskell:master Nov 3, 2020
@Bodigrim Bodigrim added this to the 0.11.1.0 milestone Nov 4, 2020
@Bodigrim Bodigrim mentioned this pull request Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants