-
Notifications
You must be signed in to change notification settings - Fork 143
Configure CI via GitHub Actions #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! I do not have a Windows machine at the moment, will take a look at failing tests next week. I wonder if #312, which removes |
|
This is getting interesting: Windows tests work fine for GHC 8.8, but fail for GHC 8.10. |
Bodigrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I can reproduce Windows failures locally, they are genuine issues (presumably with the test suite rather than with the library), and PR itself is good to be merged. Thanks!
sjakobi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a minor suggestion.
| - name: Build | ||
| run: | | ||
| cabal build all | ||
| - name: Test | ||
| run: | | ||
| cd tests && cabal test | ||
| - name: SDist | ||
| run: | | ||
| cabal sdist all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about including haddocks, and particularly benchmarks? See
Lines 51 to 54 in 1f97c4c
| # Build the benchmarks and run a single iteration. | |
| - if [ "$GHCNUMVER" -ge 71000 ]; then | |
| (cd bench; cabal v2-bench -O0 --benchmark-options "--quick --min-duration=0 --include-first-iter"); | |
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added haddocks and benchmarks. They are visible in this run: https://github.com/ethercrow/bytestring/actions/runs/336677273
dbd4f95 to
92a4cf9
Compare
sjakobi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more minor suggestion. Thanks!
|
Gentle tactical bump. |
sjakobi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Example run: https://github.com/ethercrow/bytestring/actions/runs/326555407
It actually shows that there are some issues on Windows, presumably not in the library but in the test suite.