Allow specification of custom EOA's and nonces #1138
Conversation
|
similar to you other PR, would you be able to sign off the commits so that once the pipeline issue is resolved, we can merge? Thanks! |
Signed-off-by: Viserius <[email protected]>
9c24baa to
f431d53
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bump |
|
Closing and reopening to trigger updated CI checks |
| } else if (contractInfo.estimateGas) { | ||
| params.gas = 1000 + await contractInfo.contract.methods[request.verb].estimateGas(params); | ||
| } | ||
| if (request.sender) { |
There was a problem hiding this comment.
Shouldn't this block also be present in the !request.args path? Because right now the custom sender can only be used with transactions that require some arguments. Or am I missing something?
There was a problem hiding this comment.
Hello @aklenik, it has been ages since I worked with this. Looking back at my project, you are probably right.
You can check in the following file how I used this technique (round-robin): https://github.com/Viserius/FabricBesuBenchmark/blob/master/caliper-workspace/workload/besunft-transfer.js
As you can see, I had it put in a local args variable, which might have caused the confusion of putting it in the request.args branch. Would you mind making the necessary adjustments?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Proposes a solution to #1135 , namely by allowing users to set request.sender.privateKey and request.sender.nonce.