precompiles: Add modexp changes from EIP-7823 and EIP-7883 #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1242 +/- ##
=======================================
Coverage 94.55% 94.55%
=======================================
Files 175 175
Lines 19717 19727 +10
=======================================
+ Hits 18643 18653 +10
Misses 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast
reviewed
May 28, 2025
Member
chfast
left a comment
There was a problem hiding this comment.
You should enable EEST tests on CI. This may require moving EOF out of the way.
61098a0 to
690f74b
Compare
690f74b to
d28bfe3
Compare
chfast
added a commit
that referenced
this pull request
May 29, 2025
Refactor modexp gas calculation to help with #1242.
d28bfe3 to
df24bdb
Compare
chfast
approved these changes
May 29, 2025
Implement the modexp precompile changes specified by: - [EIP-7823: Set upper bounds for MODEXP](https://eips.ethereum.org/EIPS/eip-7823) - [EIP-7883: ModExp Gas Cost Increase](https://eips.ethereum.org/EIPS/eip-7883) Co-authored-by: Paweł Bylica <[email protected]>
df24bdb to
8334999
Compare
- Add CI job to run EEST fusaka-devnet-0. - Add new modexp precompile stubs. Co-authored-by: Paweł Bylica <[email protected]>
8334999 to
2afd1b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two EIPs related expmod precompile changes in Osaka fork. EIP-7823 and EIP-7883