Skip to content

Commit

Permalink
Fixes syntax for checking if pre-commit is installed in isaaclab.sh (#…
Browse files Browse the repository at this point in the history
…1422)

# Description

When running `./isaaclab.sh --format` for another pull request, I got a
`command not found` error for `pre-commit`. Looking into the script, I
found a condition to check if `pre-commit` was installed, but the syntax
was off.

It was written like this:

```bash
if [ ! command -v pre-commit &>/dev/null ]; then
```

But it should be:

```bash
if ! command -v pre-commit &>/dev/null; then
```

I fixed it, and the script worked as expected, installing `pre-commit`
when I ran it again.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

---------

Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Co-authored-by: Kelly Guo <[email protected]>
Co-authored-by: Kelly Guo <[email protected]>
  • Loading branch information
3 people authored Dec 5, 2024
1 parent b0312db commit dbb3d4a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion isaaclab.sh
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ while [[ $# -gt 0 ]]; do
fi
# run the formatter over the repository
# check if pre-commit is installed
if [ ! command -v pre-commit &>/dev/null ]; then
if ! command -v pre-commit &>/dev/null; then
echo "[INFO] Installing pre-commit..."
pip install pre-commit
fi
Expand Down
2 changes: 1 addition & 1 deletion source/extensions/omni.isaac.lab/config/extension.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]

# Note: Semantic Versioning is used: https://semver.org/
version = "0.27.18"
version = "0.27.19"

# Description
title = "Isaac Lab framework for Robot Learning"
Expand Down
9 changes: 9 additions & 0 deletions source/extensions/omni.isaac.lab/docs/CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
Changelog
---------

0.27.19 (2024-12-05)
~~~~~~~~~~~~~~~~~~~~

Fixed
^^^^^

* Fixed the condition in ``isaaclab.sh`` that checks whether ``pre-commit`` is installed before attempting installation.


0.27.18 (2024-12-04)
~~~~~~~~~~~~~~~~~~~~

Expand Down

0 comments on commit dbb3d4a

Please sign in to comment.