Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RayCaster rough terrain base height to reward #1525

Merged

Conversation

Andy-xiong6
Copy link
Contributor

Description

Enhance base_height_l2 function to support rough terrain adjustments:

  • Added an optional sensor_cfg parameter to allow dynamic target height
    adjustments based on sensor readings (e.g., RayCaster).
  • Updated the function to calculate the L2 squared penalty using adjusted
    height values for rough terrain scenarios.
  • Preserved existing behavior for flat terrain by using the fixed target_height.
  • Improved compatibility for applications involving uneven terrain.

Fixes #1524

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • [x ] I have run the pre-commit checks with ./isaaclab.sh --format
  • [x ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • [x ] I have added my name to the CONTRIBUTORS.md or my name already exists there

Andy-xiong6

This comment was marked as duplicate.

@kellyguo11 kellyguo11 changed the title Feature/rough terrain base height reward Adds RayCaster rough terrain base height to reward Dec 13, 2024
@kellyguo11 kellyguo11 merged commit d8bc725 into isaac-sim:main Dec 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] base height reward on rough terrain
2 participants