Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds RL wrapper for skrl JAX interface #109

Closed
wants to merge 17 commits into from
Closed

Adds RL wrapper for skrl JAX interface #109

wants to merge 17 commits into from

Conversation

Toni-SM
Copy link
Contributor

@Toni-SM Toni-SM commented Aug 18, 2023

Description

Update the integration of the skrl RL library to support JAX.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with ./orbit.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file

Toni-SM added 15 commits July 28, 2023 20:04
@Toni-SM
Move the existing wrapper to a dedicated skrl folder
045b3ef
@Toni-SM
Add wrapper in JAX and update the implementation in PyTorch
9de16ec
@Toni-SM
Refactorize wrappers and trainers to avoid importing non-requested ML…
93cd54a 
… frameworks
@Toni-SM
Convert YAML types to skrl classes/components according to the select…
9ea0349 
…ed ML framework
@Toni-SM
Update train and play scripts to support JAX
785173b
@Toni-SM
Add sphinx-tabs extension to documentation
d902e4f
@Toni-SM
Update documentation
4ffe8ff
@Toni-SM
Make the parameters of the reward shaping function generic
c734b9f
@Toni-SM
Update skrl wrapper module docstring
e30b779
@Toni-SM
Update skrl version in the omni.isaac.orbit_envs extension setup.py file
e942515
@Toni-SM
Update skrl hyperparameters
119ae54
@Toni-SM
Update links to skrl docs
06e9112
@Toni-SM
Add skrl reference to RL tutorial
a6ee334
@Toni-SM
Add note for JAX version for GPU
2cbeb76
@Toni-SM
Increase omni.isaac.orbit_envs extension version and update CHANGELOG
4825829
@Toni-SM Toni-SM changed the title Skrl jax skrl JAX Aug 18, 2023
@Toni-SM Toni-SM mentioned this pull request Sep 15, 2023
Closed
@Mayankm96 Mayankm96 changed the title skrl JAX Adds RL wrapper for skrl JAX interface Sep 25, 2023
@Mayankm96 Mayankm96 mentioned this pull request Sep 25, 2023
Closed
2 tasks
@Mayankm96 Mayankm96 self-requested a review September 25, 2023 16:31
@Mayankm96 Mayankm96 added the enhancement New feature or request label Sep 25, 2023
@Toni-SM Toni-SM closed this by deleting the head repository Nov 6, 2023
Dhoeller19 pushed a commit that referenced this pull request Sep 20, 2024
@kellyguo11 @Dhoeller19
Adds thumbnails of environments in benchmarking table (#109)
16ecc77 
# Description
Adds thumbnails of environments in benchmarking table
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
@kellyguo11 @Dhoeller19
Adds thumbnails of environments in benchmarking table (isaac-sim#109)
b5b9fb2 
# Description
Adds thumbnails of environments in benchmarking table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mayankm96 Mayankm96 Mayankm96 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Toni-SM @Mayankm96 @rpapallas