-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrappers for TorchRL training workflow #1178
base: main
Are you sure you want to change the base?
Conversation
Can Vincent Moens also get tagged as a reviewer? |
In my opinion, non-wrapper code (e.g.:
Having the PPO runner code in extension will generate non-Isaac Lab related version changes and changelog records when the code need to be modified. |
This reverts commit c896e12.
I realized this causes issues with the environment specific PPO configurations, which needs to import the TorchRL PPO runner cfgs. I can move only the configs to |
Hey @fyu-bdai , can you clarify why a single environment doesn't work? |
I took another look again and fixed the single env training bug with TorchRL. |
Description
Adds TorchRL module wrappers, PPO runner, and PPO runner cfg for training IsaacLab environments with TorchRL.
This PR is the first in a series of three that together, adds a complete training pipeline for the Anymal-D training environment using torchrl. This PR contains core wrapper modules that should be merged first.
Related PRs:
#1179 Adds torchrl play and train scripts.
#1180 Adds Anymal-D torchrl training configuration.
Fixes #1181
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there