Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTX Lidar Sensor #1372

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Add RTX Lidar Sensor #1372

wants to merge 25 commits into from

Conversation

jtigue-bdai
Copy link
Collaborator

@jtigue-bdai jtigue-bdai commented Nov 4, 2024

Description

This PR creates a sensor based on the RTX Lidar:
Fixes #865

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@jtigue-bdai jtigue-bdai self-assigned this Nov 4, 2024
@jtigue-bdai jtigue-bdai changed the title Jat/feat/rtx lidar Add RTX Lidar Sensor Nov 7, 2024
@jtigue-bdai jtigue-bdai added enhancement New feature or request dev team Issue or pull request created by the dev team labels Nov 7, 2024
@jtigue-bdai
Copy link
Collaborator Author

@Dhoeller19

@jtigue-bdai jtigue-bdai mentioned this pull request Nov 22, 2024
6 tasks
env_ids = self._ALL_INDICES
# reset the data
# note: this recomputation is useful if one performs events such as randomizations on the camera poses.
# self._update_poses(env_ids)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it still make sense to do this call?

Copy link
Collaborator Author

@jtigue-bdai jtigue-bdai Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this case the _update_poses in the camera changes the pose in ._data to use the correct convention. This is unnecessary for lidar assuming the lidar pattern rotates about its Z axis.

@kellyguo11
Copy link
Contributor

@jtigue-bdai will you get a chance to look into this one today? I can also try to get this one merged in.

@jtigue-bdai
Copy link
Collaborator Author

I don't think I will be able to get to it today.

@pascal-roth
Copy link
Collaborator

pascal-roth commented Jan 3, 2025

What do you think about including some speed information or at least a warning that the RTXLidar is not batched? If I read the code correctly, then there is an annotator created for each environment instance, which will make it very costly when there are multiple environments, which can lead to confusion as all our other sensors are natively batched and, therefore faster

@jtigue-bdai
Copy link
Collaborator Author

What do you think about including some speed information or at least a warning that the RTXLidar is not batched? If I read the code correctly, then there is an annotator created for each environment instance, which will make it very costly when there are multiple environments, which can lead to confusion as all our other sensors are natively batched and, therefore faster

@pascal-roth I have no problem with a warning but isn't the USD camera setup the same way?

@pascal-roth
Copy link
Collaborator

oh true, you are correct, then I remembered that incorrectly, in this case I don't think a warning is necessary. Ignore the comment then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev team Issue or pull request created by the dev team enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RTX Lidar sensor
3 participants