-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTX Lidar Sensor #1372
base: main
Are you sure you want to change the base?
Add RTX Lidar Sensor #1372
Conversation
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/rtx_lidar/rtx_lidar.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/rtx_lidar/rtx_lidar.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/rtx_lidar/rtx_lidar_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/rtx_lidar/rtx_lidar_data.py
Outdated
Show resolved
Hide resolved
env_ids = self._ALL_INDICES | ||
# reset the data | ||
# note: this recomputation is useful if one performs events such as randomizations on the camera poses. | ||
# self._update_poses(env_ids) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it still make sense to do this call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this case the _update_poses in the camera changes the pose in ._data to use the correct convention. This is unnecessary for lidar assuming the lidar pattern rotates about its Z axis.
@jtigue-bdai will you get a chance to look into this one today? I can also try to get this one merged in. |
I don't think I will be able to get to it today. |
…dar/rtx_lidar.py Signed-off-by: Kelly Guo <[email protected]>
…dar/rtx_lidar_data.py Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: James Tigue <[email protected]>
What do you think about including some speed information or at least a warning that the RTXLidar is not batched? If I read the code correctly, then there is an annotator created for each environment instance, which will make it very costly when there are multiple environments, which can lead to confusion as all our other sensors are natively batched and, therefore faster |
@pascal-roth I have no problem with a warning but isn't the USD camera setup the same way? |
oh true, you are correct, then I remembered that incorrectly, in this case I don't think a warning is necessary. Ignore the comment then |
Description
This PR creates a sensor based on the RTX Lidar:
Fixes #865
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there