Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add torque readings for implicit actuator #172

Closed

Conversation

chaofiber
Copy link

This MR makes the following changes:

  • Add torque readings for implicit actuators
  • I have run the pre-commit checks with
    ./orbit.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my
    feature works
  • I have updated the changelog and the corresponding version in the
    extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already
    exists there

@Mayankm96
Copy link
Contributor

Hi, thanks a lot for this MR. Can we add a unit test to check if the torques we obtain from the implicit models are similar to those we see with explicit models when we use a simple PD actuator model. In principle, it should be close if dt is small.

@Mayankm96 Mayankm96 deleted the branch isaac-sim:devel December 22, 2023 08:25
@Mayankm96 Mayankm96 closed this Dec 22, 2023
Mayankm96 added a commit that referenced this pull request Dec 22, 2023
# Description

From Isaac Sim 2023.X onwards (Kit 105.X onwards), there are various
noticeable changes that include renaming certain extensions and
upgrading to the latest USD.

This MR ensures that Orbit remains compatible with the coming release of
Isaac Sim while still supporting 2022.2.1.

## Type of change

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [x] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file

---------

Signed-off-by: Mayank Mittal <[email protected]>
Co-authored-by: Nikita Rudin <[email protected]>
Co-authored-by: AutonomousHansen <[email protected]>
Co-authored-by: jsmith-bdai <[email protected]>
Mayankm96 added a commit that referenced this pull request Dec 22, 2023
# Description

From Isaac Sim 2023.X onwards (Kit 105.X onwards), there are various
noticeable changes that include renaming certain extensions and
upgrading to the latest USD.

This MR ensures that Orbit remains compatible with the coming release of
Isaac Sim while still supporting 2022.2.1.

## Type of change

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [x] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file

---------

Signed-off-by: Mayank Mittal <[email protected]>
Co-authored-by: Nikita Rudin <[email protected]>
Co-authored-by: AutonomousHansen <[email protected]>
Co-authored-by: jsmith-bdai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants