Promises basics #3285
Open
Promises basics #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| The call `.finally(f)` is similar to `.then(f, f)` in the sense that `f` runs always, when the promise is settled: be it resolve or reject. | ||
|
|
||
| The idea of `finally` is to set up a handler for performing cleanup/finalizing after the previous operations are complete. | ||
|
|
||
| E.g. stopping loading indicators, closing no longer needed connections, etc. | ||
|
|
||
| Think of it as a party finisher. No matter was a party good or bad, how many friends were in it, we still need (or at least should) do a cleanup after it. | ||
| Think of it as a party finisher. No matter if a party was good or bad, how many friends were in it, we still need (or at least should) do a cleanup after it. |
There was a problem hiding this comment.
i prefer the solution at #3390
| @@ -214,15 +214,15 @@ The call `.catch(f)` is a complete analog of `.then(null, f)`, it's just a short | |||
|
|
|||
| ## Cleanup: finally | |||
|
|
|||
| Just like there's a `finally` clause in a regular `try {...} catch {...}`, there's `finally` in promises. | |||
| Just like there's a `finally` clause in a regular `try {...} catch {...}`, there's a `finally` in promises also. | |||
There was a problem hiding this comment.
maybe:
Just like there's a
finallyclause in a regulartry {...} catch {...}, there's afinallyfor promise chains.
| @@ -291,7 +291,7 @@ Sometimes, it might be that a promise is already settled when we add a handler t | |||
| In such case, these handlers just run immediately: | |||
|
|
|||
| ```js run | |||
| // the promise becomes resolved immediately upon creation | |||
| // the promise becomes settled immediately upon creation | |||
There was a problem hiding this comment.
disagree, 'resolve' goes well with use of resolve in the article's examples. Maybe 'fulfilled' if trying to use ECMA term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lines 294 and 327 refer to line 84:
Lines 227 and 225 just have some potentially good improvements for readability.