Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises basics #3285

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Promises basics #3285

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da53cf3
line 217
bogdanbacosca Nov 29, 2022
79a66e3
line 225
bogdanbacosca Nov 29, 2022
706b8e6
line 294
bogdanbacosca Nov 29, 2022
ee44f80
line 327
bogdanbacosca Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
line 294 
Replaced resolved with settled for consistency.
  • Loading branch information
@bogdanbacosca
bogdanbacosca committed Nov 29, 2022
commit 706b8e6b58366595cd77e84ea6b9b96f58e3d854
2 changes: 1 addition & 1 deletion 1-js/11-async/02-promise-basics/article.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ Sometimes, it might be that a promise is already settled when we add a handler t
In such case, these handlers just run immediately:

```js run
// the promise becomes resolved immediately upon creation
// the promise becomes settled immediately upon creation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disagree, 'resolve' goes well with use of resolve in the article's examples. Maybe 'fulfilled' if trying to use ECMA term.

let promise = new Promise(resolve => resolve("done!"));

promise.then(alert); // done! (shows up right now)
Expand Down