Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable signing for nightlies #643

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Disable signing for nightlies #643

merged 6 commits into from
Aug 19, 2024

Conversation

Jaifroid
Copy link
Member

Fixes #642.

@Jaifroid
Copy link
Member Author

It was so hard to get electron-builder to sign correctly in the first place, you'd have thought it would be easy to disable signing. Nothing as simple as a switch, oh no. Here's what worked eventually:

  • Created a custom configuration file (electronBuilder.cjs) that:
    • Loads the base configuration from package.json
    • Removes all signing-related properties (certificateSha1, signingHashAlgorithms, rfc3161TimeStampServer, and sign) from the win object
    • Unsets top-level signing configs (cscLink and cscKeyPassword)

This is loaded via two -unsigned package.json scripts that are called conditionally.

@Jaifroid Jaifroid merged commit cf52cc8 into main Aug 19, 2024
3 checks passed
@Jaifroid Jaifroid deleted the Disable-signing-for-nightlies branch August 19, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix nightly build of Windows packages
1 participant