Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable signing for nightlies #643

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Disable signing for nightlies #643

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f79615
Disable signing for nightlies
Jaifroid Aug 19, 2024
9b3a9a1
Fix build commands
Jaifroid Aug 19, 2024
798c147
Try a different approach
Jaifroid Aug 19, 2024
9d10565
Try yet another obscure approach, sigh
Jaifroid Aug 19, 2024
0248b9e
Next attempt
Jaifroid Aug 19, 2024
748826c
Remove signing-related configuration
Jaifroid Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Next attempt
  • Loading branch information
@Jaifroid
Jaifroid committed Aug 19, 2024
commit 0248b9e8f46f5afad30bf136989079c0bb09bad2
8 changes: 4 additions & 4 deletions .github/workflows/build-electron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,9 @@ jobs:
if ($INPUT_SIGN) {
npm run dist-win-nsis
} else {
$Env:CSC_IDENTITY_AUTO_DISCOVERY = "false"
$Env:CSC_IDENTITY_AUTO_DISCOVERY = $False
npm run dist-win-nsis
$Env:CSC_IDENTITY_AUTO_DISCOVERY = $null
$Env:CSC_IDENTITY_AUTO_DISCOVERY = $Null
}
echo "Renaming Windows 7+ executable"
$files = @("Kiwix JS Electron", "WikiMed by Kiwix", "Wikivoyage by Kiwix")
Expand Down Expand Up @@ -305,9 +305,9 @@ jobs:
if ($INPUT_SIGN) {
npm run publish
} else {
$Env:CSC_IDENTITY_AUTO_DISCOVERY = "false"
$Env:CSC_IDENTITY_AUTO_DISCOVERY = $False
npm run build
$Env:CSC_IDENTITY_AUTO_DISCOVERY = $null
$Env:CSC_IDENTITY_AUTO_DISCOVERY = $Null
}
./scripts/Rewrite-DraftReleaseTag.ps1
- name: Build portable Electron app
Expand Down
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,12 @@
"dist-win": "electron-builder build --win --projectDir dist",
"dist-win-arm64": "electron-builder build --win NSIS:arm64 --projectDir dist",
"dist-win-nsis": "electron-builder build --win NSIS:ia32 --publish never --projectDir dist",
"dist-win-nsis-skipsigning": "electron-builder build --win NSIS:ia32 --config.win.certificateSha1=null --config.win.signingHashAlgorithms=null --config.win.rfc3161TimeStampServer=null --config.win.sign=false --publish never --projectDir dist",
"dist-win-nisis-x64": "electron-builder build --win NSIS:x64 --publish never --projectDir dist",
"dist-linux": "electron-builder build --linux --projectDir dist",
"dist-linux-appimage": "electron-builder build --linux AppImage:x64 --projectDir dist",
"publish": "electron-builder build --projectDir dist",
"build-skipsigning": "electron-builder build --config.win.certificateSha1=null --config.win.signingHashAlgorithms=null --config.win.rfc3161TimeStampServer=null --config.win.sign=false --publish never --projectDir dist",
"postpackage-win": "(robocopy archives bld\\Electron\\kiwix-js-pwa-win32-ia32\\resources\\app\\archives\\ > null) ^& IF %ERRORLEVEL% LSS 8 SET ERRORLEVEL = 0",
"postpackage-linux": "(robocopy archives bld\\Electron\\kiwix-js-pwa-linux-x64\\archives\\ > null) ^& IF %ERRORLEVEL% LSS 8 SET ERRORLEVEL = 0"
},
Expand Down