Update etcd version to 3.1.11 for release 1.9 #57811

xiangpengzhao · 2018-01-04T01:44:37Z

What this PR does / why we need it:

This is fixing some bugs in HA setups.

ref: #57238
#57633 (review) and discussions in that thread.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
ref: #57238

Special notes for your reviewer:
/cc @wojtek-t @luxas @jpbetz @mbohlool

Release note:

Update etcd version to 3.1.11

xiangpengzhao · 2018-01-04T01:53:12Z

bazel failed due to

ERROR: /workspace/k8s.io/kubernetes/test/integration/framework/BUILD:8:1: no such package '@com_coreos_etcd//': Error downloading [https://github.com/coreos/etcd/releases/download/v3.1.11/etcd-v3.1.11-linux-amd64.tar.gz] to /root/.cache/bazel/_bazel_root/e9f728bbd90b3fba632eb31b20e1dacd/external/com_coreos_etcd/etcd-v3.1.11-linux-amd64.tar.gz: Checksum was b80c6c0719beee703821ece80f9e48b071ad5f59bb284bd3ea2104700738d9ec but wanted 2d335f298619c6fb02b1124773a56966e448ad9952b26fea52909da4fe80d2be and referenced by '//test/integration/framework:go_default_library'

@jpbetz any ideas?

wojtek-t · 2018-01-04T07:14:18Z

Godeps/Godeps.json

@@ -442,47 +437,47 @@
 		},
 		{
 			"ImportPath": "github.com/containerd/containerd/api/services/containers/v1",
-			"Comment": "v1.0.0-beta.2-159-g27d450a0",
+			"Comment": "v1.0.0-beta.2-159-g27d450a",


Why are we bumping all of these too? Are those really transitive dependencies of etcd client?

I just followed the guide Using godep to manage dependencies and it updated godeps for me. I'm not sure why this was updated. But maybe it's a mistake: g27d450a0 vs g27d450a. I will revert it manually.

Took another look and found that this is just a Comment change. I guess it's a upstream Comment change. Here it doesn't bump the real code.

See also: #57811 (comment)

wojtek-t · 2018-01-04T07:16:52Z

@xiangpengzhao - thanks a lot for putting this together.
Did you have a chance to look into test failures? Those doesn't seem like flakes to me

xiangpengzhao · 2018-01-05T07:09:45Z

Did you have a chance to look into test failures? Those doesn't seem like flakes to me

The log shows the checksum of etcd-v3.1.11-linux-amd64.tar.gz is incorrect. @jpbetz do you know what may cause this failure? Thanks!

ERROR: /workspace/k8s.io/kubernetes/test/integration/framework/BUILD:8:1: no such package 
'@com_coreos_etcd//': Error downloading 
[https://github.com/coreos/etcd/releases/download/v3.1.11/etcd-v3.1.11-linux-amd64.tar.gz] to 
/root/.cache/bazel/_bazel_root/e9f728bbd90b3fba632eb31b20e1dacd/external/com_coreos_etcd/etcd-
v3.1.11-linux-amd64.tar.gz: Checksum was 
b80c6c0719beee703821ece80f9e48b071ad5f59bb284bd3ea2104700738d9ec but wanted 
2d335f298619c6fb02b1124773a56966e448ad9952b26fea52909da4fe80d2be and referenced by 
'//test/integration/framework:go_default_library'

UPDATE: find the clue here #49393 (comment). Thanks @mikedanese ! :)

xiangpengzhao · 2018-01-05T07:27:37Z

Godeps/Godeps.json

 			"Rev": "edc3ab29cdff8694dd6feb85cfeb4b5f1b38ed9c"
 		},
 		{
 			"ImportPath": "github.com/docker/docker/api",
-			"Comment": "docs-v1.12.0-rc4-2016-07-15-7401-g4f3616fb1",
+			"Comment": "docs-v1.12.0-rc4-2016-07-15-7401-g4f3616f",


we can seee the Godeps.json file in openshift. Its Comment is also docs-v1.12.0-rc4-2016-07-15-7401-g4f3616f.
https://github.com/openshift/origin/blob/master/Godeps/Godeps.json#L1219

{ "ImportPath": "github.com/docker/docker/api", "Comment": "docs-v1.12.0-rc4-2016-07-15-7401-g4f3616f", "Rev": "4f3616fb1c112e206b88cb7a9922bf49067a7756" },

xiangpengzhao · 2018-01-05T08:49:36Z

@wojtek-t @mbohlool all tests passed, PTAL. Thanks!

wojtek-t · 2018-01-05T09:03:11Z

/lgtm

k8s-ci-robot · 2018-01-05T09:03:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t, xiangpengzhao

Associated issue: #57238

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [wojtek-t]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

xiangpengzhao · 2018-01-05T09:07:05Z

@wojtek-t thanks!
ping @mbohlool for cherry-picking approval. Sorry for missing the 1.9.1 train...

mbohlool · 2018-01-08T20:13:31Z

Why didn't you use automatic tools to cherrypick #57238?

wojtek-t · 2018-01-08T20:36:12Z

@mbohlool - this is a different PR; that was just for build an image. This is bumping dependencies and using that image.
There wasn't corresponding PR in master branch, since we bumped etcd there directly to 3.2.12.

k8s-github-robot · 2018-01-11T00:00:00Z

/test all [submit-queue is verifying that this PR is safe to merge]

xiangpengzhao · 2018-01-11T01:28:13Z

/test pull-kubernetes-unit

k8s-github-robot · 2018-01-11T02:26:53Z

/test all

Tests are more than 96 hours old. Re-running tests.

fejta-bot · 2018-01-11T04:45:36Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

k8s-github-robot · 2018-01-11T05:23:27Z

/test all

Tests are more than 96 hours old. Re-running tests.

xiangpengzhao · 2018-01-11T05:49:23Z

/retest

k8s-github-robot · 2018-01-11T07:21:11Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-01-11T07:21:31Z

/test all

Tests are more than 96 hours old. Re-running tests.

k8s-github-robot · 2018-01-11T08:21:34Z

Automatic merge from submit-queue.

update godep for etcd-client to 3.1.11 in 1.9 branch

9db0305

k8s-ci-robot requested review from jpbetz, luxas, mbohlool and wojtek-t January 4, 2018 01:44

k8s-github-robot assigned timothysc and lavalamp Jan 4, 2018

k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 4, 2018

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 4, 2018

xiangpengzhao mentioned this pull request Jan 4, 2018

Cherrypicking tracker issue for v1.9 kubernetes/kubeadm#626

Closed

3 tasks

wojtek-t reviewed Jan 4, 2018

View reviewed changes

wojtek-t assigned jpbetz and wojtek-t Jan 4, 2018

xiangpengzhao commented Jan 5, 2018

View reviewed changes

update etcd version to 3.1.11 in 1.9 branch

546d7df

xiangpengzhao force-pushed the branch1.9 branch from a806bfb to 546d7df Compare January 5, 2018 07:36

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2018

mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 10, 2018

k8s-github-robot merged commit 396b9d0 into kubernetes:release-1.9 Jan 11, 2018

xiangpengzhao deleted the branch1.9 branch January 11, 2018 09:32

xiangpengzhao mentioned this pull request Feb 2, 2018

Update kubeadm supported etcd version to 3.2.14 in 1.10 #57230

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update etcd version to 3.1.11 for release 1.9 #57811

Update etcd version to 3.1.11 for release 1.9 #57811

xiangpengzhao commented Jan 4, 2018 •

edited

Loading

xiangpengzhao commented Jan 4, 2018

wojtek-t Jan 4, 2018

xiangpengzhao Jan 5, 2018

xiangpengzhao Jan 5, 2018

xiangpengzhao Jan 5, 2018

wojtek-t commented Jan 4, 2018

xiangpengzhao commented Jan 5, 2018 •

edited

Loading

xiangpengzhao Jan 5, 2018

xiangpengzhao commented Jan 5, 2018

wojtek-t commented Jan 5, 2018

k8s-ci-robot commented Jan 5, 2018

xiangpengzhao commented Jan 5, 2018

mbohlool commented Jan 8, 2018

wojtek-t commented Jan 8, 2018

k8s-github-robot commented Jan 11, 2018

xiangpengzhao commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

fejta-bot commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

xiangpengzhao commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

Update etcd version to 3.1.11 for release 1.9 #57811

Update etcd version to 3.1.11 for release 1.9 #57811

Conversation

xiangpengzhao commented Jan 4, 2018 • edited Loading

xiangpengzhao commented Jan 4, 2018

wojtek-t Jan 4, 2018

Choose a reason for hiding this comment

xiangpengzhao Jan 5, 2018

Choose a reason for hiding this comment

xiangpengzhao Jan 5, 2018

Choose a reason for hiding this comment

xiangpengzhao Jan 5, 2018

Choose a reason for hiding this comment

wojtek-t commented Jan 4, 2018

xiangpengzhao commented Jan 5, 2018 • edited Loading

xiangpengzhao Jan 5, 2018

Choose a reason for hiding this comment

xiangpengzhao commented Jan 5, 2018

wojtek-t commented Jan 5, 2018

k8s-ci-robot commented Jan 5, 2018

xiangpengzhao commented Jan 5, 2018

mbohlool commented Jan 8, 2018

wojtek-t commented Jan 8, 2018

k8s-github-robot commented Jan 11, 2018

xiangpengzhao commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

fejta-bot commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

xiangpengzhao commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

k8s-github-robot commented Jan 11, 2018

xiangpengzhao commented Jan 4, 2018 •

edited

Loading

xiangpengzhao commented Jan 5, 2018 •

edited

Loading