-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to reduce repainting #5876
Conversation
- Related fixes for search/filter inputs in telemetry tables.
- Changes to reduce paints and improve performance. - Remove/refactor `filter`-based hover styles. - New `cControlHov` mixin that uses `box-shadow` instead of `filter`. - Refactor `transition: all` to use more specific properties. - New `transition` mixin for above. - Cleanup; removed unused hover and style definitions.
- Cleanup.
Codecov Report
@@ Coverage Diff @@
## master #5876 +/- ##
==========================================
- Coverage 54.81% 54.03% -0.79%
==========================================
Files 626 626
Lines 26630 26630
Branches 2405 2405
==========================================
- Hits 14598 14390 -208
- Misses 11370 11577 +207
- Partials 662 663 +1
*This pull request uses carry forward flags. Click here to find out more. see 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- Convert `__pane-main` to use absolute positioning to isolate object view and Time Conductor from page reflowing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me!
@michaelrogers to address any broken tests and merge. |
@michaelrogers to fix tests and merge |
From the failed e2e tests traces, it looks like the "Edit & Save" button is disappeared? |
This one needs some additional work. We should move it back into draft |
Resolved Failing Tests
|
Closes #5247. Test instructions not yet included in the #5247 - will update there after we determine the best way to actually test these changes.
Describe your changes:
filter
hover effect that seemed to cause a lot of repaints; replaced with abox-shadow
effect in buttons and simple background color changes in other elements.transition: all
to use specific properties instead via new mixintransition
.__pane-main
to use absolute positioning to isolate object view and Time Conductor from page reflowing.All Submissions:
Author Checklist
Reviewer Checklist