Closes #5247

- WIP! Comments and radioactive trace colors added. - Added comments, many items to be refactored.
nasa · unlikelyzero · Mar 17, 2023 · Jul 26, 2022 · Aug 16, 2022 · Oct 11, 2022
commit 2af41494971fe450a474433efcc4044a1bd40a1c
diff --git a/src/api/overlays/components/overlay-component.scss b/src/api/overlays/components/overlay-component.scss
@@ -81,7 +81,9 @@
     }
 
     .c-object-label__name {
-        filter: $objectLabelNameFilter;
+        // FILTER REMOVAL
+        //filter: $objectLabelNameFilter;
+        color: deeppink !important;
     }
 }
 

diff --git a/src/plugins/folderView/components/grid-view.scss b/src/plugins/folderView/components/grid-view.scss
@@ -42,7 +42,7 @@
     padding: $interiorMarginLg;
 
     &__type-icon {
-        filter: $colorKeyFilter;
+        filter: $colorKeyFilter; // FILTER REMOVAL
         flex: 0 0 $gridItemMobile;
         font-size: floor(math.div($gridItemMobile, 2));
         margin-right: $interiorMarginLg;
@@ -145,7 +145,7 @@
         transition: $transOutMs ease-in-out;
 
         &:hover {
-            filter: $filterItemHoverFg;
+            //filter: $filterItemHoverFg; // FILTER REMOVAL
             transition: $transIn;
 
             .c-grid-item__type-icon {

diff --git a/src/plugins/imagery/components/imagery-view.scss b/src/plugins/imagery/components/imagery-view.scss
@@ -476,7 +476,7 @@
         &:hover {
             z-index: 2;
 
-            filter: brightness(1) contrast(1) !important;
+            //filter: brightness(1) contrast(1) !important; // FILTER REMOVAL
             [class*='__image-handle'] {
                 background-color: $colorBodyFg;
             }
@@ -503,6 +503,6 @@
 
     &:hover div.c-imagery-tsv__image-wrapper {
         // TODO CH: convert to theme constants
-        filter: brightness(0.5) contrast(0.7);
+        filter: brightness(0.5) contrast(0.7); // FILTER REMOVAL
     }
 }
diff --git a/src/plugins/timeConductor/conductor-mode.scss b/src/plugins/timeConductor/conductor-mode.scss
@@ -5,7 +5,7 @@
     z-index: 70;
 
     [class*="__icon"] {
-        filter: $colorKeyFilter;
+        filter: $colorKeyFilter; // FILTER REMOVAL
     }
 
     [class*="__item-description"] {

diff --git a/src/plugins/timeConductor/conductor.scss b/src/plugins/timeConductor/conductor.scss
@@ -68,7 +68,7 @@
                 &:hover,
                 &:active {
                     cursor: col-resize;
-                    filter: $timeConductorAxisHoverFilter;
+                    filter: $timeConductorAxisHoverFilter; // FILTER REMOVAL, CONVERT TO THEME CONSTANT
                 }
             }
         }
@@ -269,7 +269,7 @@
     grid-column-gap: 3px;
     grid-row-gap: 4px;
     align-items: start;
-    filter: $filterMenu;
+    //filter: $filterMenu; // FILTER REMOVAL
     box-shadow: $shdwMenu;
     padding: $interiorMargin;
     position: absolute;

diff --git a/src/styles/_constants-espresso.scss b/src/styles/_constants-espresso.scss
@@ -86,7 +86,7 @@ $colorSelectedFg: pullForward($colorBodyFg, 20%);
 
 // Object labels
 $objectLabelTypeIconOpacity: 0.7;
-$objectLabelNameFilter: brightness(1.3);
+$objectLabelNameFilter: brightness(1.3); // FILTER REMOVAL
 
 // Layout
 $shellMainPad: 4px 0;

diff --git a/src/styles/_controls.scss b/src/styles/_controls.scss
@@ -547,7 +547,7 @@ select {
     }
 
     @include hover() {
-        filter: $filterHov;
+        //filter: $filterHov; // FILTER REMOVAL, CONVERT TO THEME CONSTANT
     }
 
     &.is-current {
@@ -1116,7 +1116,7 @@ input[type="range"] {
         background-repeat: no-repeat;
         content: '';
         display: block;
-        filter: $colorKeyFilterHov;
+        //filter: $colorKeyFilterHov; // FILTER REMOVAL, CONVERT TO THEME CONSTANT
         height: $h; width: $h;
         max-height: $mh; max-width: $mh;
     }

diff --git a/src/styles/_mixins.scss b/src/styles/_mixins.scss
@@ -498,7 +498,8 @@
     }
 
     @include hover() {
-        filter: $filterHov;
+        background: deeppink !important;
+        //filter: $filterHov; // FILTER REMOVAL, CONVERT TO THEME CONSTANT
     }
 
     &[class*="--major"],
@@ -563,9 +564,9 @@
 
     @include hover() {
         transition: $transIn;
-        background: $colorClickIconButtonBgHov;
+        background: green !important; //$colorClickIconButtonBgHov;
         //color: $colorClickIconButtonFgHov;
-        filter: $filterHov;
+        //filter: $filterHov;  // FILTER REMOVAL, CONVERT TO THEME CONSTANT
     }
 
     &[class*="--major"] {
@@ -624,7 +625,8 @@
     }
 
     @include hover {
-        filter: $filterHov;
+        //filter: $filterHov; // FILTER REMOVAL, CONVERT TO THEME CONSTANT
+        color: deeppink !important;
     }
 
     &--up, &--prev {

diff --git a/src/ui/components/List/list-view.scss b/src/ui/components/List/list-view.scss
@@ -22,7 +22,7 @@
 
                 &:hover {
                     background: $colorListItemBgHov;
-                    filter: $filterHov;
+                    //filter: $filterHov;  // FILTER REMOVAL, CONVERT TO THEME CONSTANT
                     transition: $transIn;
                 }
             }

diff --git a/src/ui/components/object-frame.scss b/src/ui/components/object-frame.scss
@@ -20,7 +20,8 @@
             }
 
             &__name {
-                filter: $objectLabelNameFilter;
+                //filter: $objectLabelNameFilter; // FILTER REMOVAL, CONVERT TO THEME CONSTANT
+                color: deeppink !important;
             }
         }
     }

diff --git a/src/ui/inspector/inspector.scss b/src/ui/inspector/inspector.scss
@@ -26,7 +26,7 @@
 
     &__selected {
         .c-object-label__name {
-            filter: $objectLabelNameFilter;
+            //filter: $objectLabelNameFilter; // FILTER REMOVAL, CONVERT TO THEME CONSTANT
         }
 
         .c-object-label__type-icon {

diff --git a/src/ui/inspector/location.scss b/src/ui/inspector/location.scss
@@ -26,21 +26,21 @@
     flex-wrap: wrap;
 
     &__item {
+        $m: 1px;
         cursor: pointer;
-        margin: 0 $interiorMarginSm $interiorMarginSm 0;
+        margin: 0 $m $m 0;
 
         .c-object-label {
-            padding: 0;
-            transition: $transOut;
+            border-radius: $smallCr;
+            padding: 2px 3px;
 
             &__type-icon {
                 width: auto;
                 font-size: 1em;
             }
 
-            &:hover {
-                transition: $transIn;
-                filter: $filterHov;
+            @include hover() {
+                background: $colorItemTreeHoverBg;
             }
         }
     }

diff --git a/src/ui/layout/create-button.scss b/src/ui/layout/create-button.scss
@@ -20,7 +20,7 @@
     z-index: 70;
 
     [class*="__icon"] {
-        filter: $colorKeyFilter;
+        filter: $colorKeyFilter;  // FILTER REMOVAL, CONVERT TO THEME CONSTANT
     }
 
     [class*="__item-description"] {

diff --git a/src/ui/layout/layout.scss b/src/ui/layout/layout.scss
@@ -403,7 +403,7 @@
     }
 
     .c-object-label__name {
-        filter: $objectLabelNameFilter;
+        //filter: $objectLabelNameFilter; // FILTER REMOVAL, CONVERT TO THEME CONSTANT
     }
 
     .c-object-label__type-icon {

diff --git a/src/ui/layout/mct-tree.scss b/src/ui/layout/mct-tree.scss
@@ -97,7 +97,7 @@
 
         @include hover {
             background: $colorItemTreeHoverBg;
-            filter: $filterHov;
+            //filter: $filterHov; // FILTER REMOVAL, CONVERT TO THEME CONSTANT
         }
 
         &.is-navigated-object,
@@ -188,14 +188,6 @@
             }
         }
     }
-
-    &__item__label {
-        @include desktop {
-            &:hover {
-                filter: $filterHov;
-            }
-        }
-    }
 }
 
 .is-editing .is-navigated-object {