fix slow loading errors

src/api/telemetry/TelemetryCollection.js

@@ -73,6 +73,10 @@ export default class TelemetryCollection extends EventEmitter {
     this.isStrategyLatest = this.options.strategy === 'latest';
     this.dataOutsideTimeBounds = false;
     this.modeChanged = false;
+
+    console.debug(
+      `🫙 Created telemetry for ${this.domainObject.name} with bounds ${options.start} and ${options.end}`
+    );
   }
 
   /**
@@ -86,6 +90,16 @@ export default class TelemetryCollection extends EventEmitter {
 
     this._setTimeSystem(this.options.timeContext.getTimeSystem());
     this.lastBounds = this.options.timeContext.getBounds();
+    // prioritize passed options over time bounds
+    if (this.options.start) {
+      this.lastBounds.start = this.options.start;
+    }
+    if (this.options.end) {
+      this.lastBounds.end = this.options.end;
+    }
+    console.debug(
+      `🫙 Bounds for collection are start ${this.lastBounds.start} and end ${this.lastBounds.end}`
+    );
     this._watchBounds();
     this._watchTimeSystem();
     this._watchTimeModeChange();
@@ -215,20 +229,13 @@ export default class TelemetryCollection extends EventEmitter {
     let hasDataBeforeStartBound = false;
     let size = this.options.size;
     let enforceSize = size !== undefined && this.options.enforceSize;
-    // prioritize request bounds over time context bounds
-    let boundsToUse = this.lastBounds;
-    if (this.options.start) {
-      boundsToUse.start = this.options.start;
-    }
-    if (this.options.end) {
-      boundsToUse.end = this.options.end;
-    }
+    console.debug(`🫙 Bounds are telemetry are currently`, this.lastBounds);
 
     // loop through, sort and dedupe
     for (let datum of data) {
       parsedValue = this.parseTime(datum);
-      beforeStartOfBounds = parsedValue < boundsToUse.start;
-      afterEndOfBounds = parsedValue > boundsToUse.end;
+      beforeStartOfBounds = parsedValue < this.lastBounds.start;
+      afterEndOfBounds = parsedValue > this.lastBounds.end;
 
       if (
         !afterEndOfBounds &&
@@ -335,6 +342,10 @@ export default class TelemetryCollection extends EventEmitter {
       return;
     }
 
+    console.debug(
+      `🫙 Bounds CHANGED for ${this.domainObject.name} are start ${bounds.start} and end ${bounds.end}`
+    );
+
     let startChanged = this.lastBounds.start !== bounds.start;
     let endChanged = this.lastBounds.end !== bounds.end;
 

src/plugins/comps/CompsManager.js

@@ -7,14 +7,11 @@
   #composition;
   #telemetryObjects = {};
   #telemetryCollections = {};
-  #dataFrame = {};
   #telemetryLoadedPromises = [];
   #telemetryOptions = {};
   #loaded = false;
   #compositionLoaded = false;
   #telemetryProcessors = {};
-  // make id random 4 digit number
-  #id = Math.floor(Math.random() * 9000) + 1000;
 
   constructor(openmct, domainObject) {
     super();
@@ -37,7 +34,7 @@
         }
       }
       // Increment suffix after exhausting the alphabet
       suffix = (parseInt(suffix, 10) || 0) + 1;
     }
   }
 
@@ -55,7 +52,7 @@
     let valueToUse = rangeItems[0]?.key;
     if (!valueToUse) {
       // if no numeric data type, just use the first one
       valueToUse = metaData.valueMetadatas[0]?.key;
     }
     this.#domainObject.configuration.comps.parameters.push({
       keyString,
@@ -89,16 +86,16 @@
   }
 
   deleteParameter(keyString) {
     this.#domainObject.configuration.comps.parameters =
       this.#domainObject.configuration.comps.parameters.filter(
         (parameter) => parameter.keyString !== keyString
       );
     // if there are no parameters referencing this parameter keyString, remove the telemetry object too
     const parameterExists = this.#domainObject.configuration.comps.parameters.some(
       (parameter) => parameter.keyString === keyString
     );
     if (!parameterExists) {
       this.emit('parameterRemoved', this.#domainObject);
     }
   }
 
@@ -111,9 +108,12 @@
   }
 
   async load(telemetryOptions) {
-    // if our options change, we need to reload the composition
     if (!_.isEqual(telemetryOptions, this.#telemetryOptions) && this.#loaded) {
+      console.debug(
+        `😩 Reloading comps manager ${this.#domainObject.name} due to telemetry options change`,
+        telemetryOptions
+      );
       this.#destroy();
     }
     this.#telemetryOptions = telemetryOptions;
     if (!this.#compositionLoaded) {
@@ -121,13 +121,13 @@
       this.#compositionLoaded = true;
     }
     if (!this.#loaded) {
-      await this.startListeningToUnderlyingTelemetry();
+      await this.#startListeningToUnderlyingTelemetry();
       this.#telemetryLoadedPromises = [];
       this.#loaded = true;
     }
   }
 
-  async startListeningToUnderlyingTelemetry() {
+  async #startListeningToUnderlyingTelemetry() {
     Object.keys(this.#telemetryCollections).forEach((keyString) => {
       if (!this.#telemetryCollections[keyString].loaded) {
         this.#telemetryCollections[keyString].on('add', this.#getTelemetryProcessor(keyString));
@@ -141,12 +141,12 @@
   }
 
   #destroy() {
     this.stopListeningToUnderlyingTelemetry();
     this.#composition = null;
     this.#telemetryCollections = {};
     this.#compositionLoaded = false;
     this.#loaded = false;
     this.#telemetryObjects = {};
   }
 
   stopListeningToUnderlyingTelemetry() {
@@ -161,7 +161,7 @@
   }
 
   getTelemetryObjects() {
     return this.#telemetryObjects;
   }
 
   async #loadComposition() {
@@ -185,7 +185,7 @@
     dataFrame[newTelemetryKey] = newTelemetryData;
     // initialize the other telemetry data
     otherTelemetryKeys.forEach((keyString) => {
       dataFrame[keyString] = [];
     });
 
     // march through the new telemetry data and add data to the frame from the other telemetry objects
@@ -193,16 +193,16 @@
 
     newTelemetryData.forEach((newDatum) => {
       otherTelemetryKeys.forEach((otherKeyString) => {
         const otherCollection = this.#telemetryCollections[otherKeyString];
         let insertionPointForNewData = otherCollection._sortedIndex(newDatum);
         const otherCollectionData = otherCollection.getAll();
         if (insertionPointForNewData && insertionPointForNewData >= otherCollectionData.length) {
           insertionPointForNewData = otherCollectionData.length - 1;
         }
         // get the closest datum to the new datum
         const closestDatum = otherCollectionData[insertionPointForNewData];
         if (closestDatum) {
           dataFrame[otherKeyString].push(closestDatum);
         }
       });
     });
@@ -210,12 +210,12 @@
   }
 
   #removeTelemetryObject = (telemetryObjectIdentifier) => {
     const keyString = this.#openmct.objects.makeKeyString(telemetryObjectIdentifier);
     delete this.#telemetryObjects[keyString];
     this.#telemetryCollections[keyString]?.destroy();
     delete this.#telemetryCollections[keyString];
     // remove all parameters that reference this telemetry object
     this.deleteParameter(keyString);
   };
 
   requestUnderlyingTelemetry() {
@@ -229,7 +229,7 @@
 
   #getTelemetryProcessor(keyString) {
     if (this.#telemetryProcessors[keyString]) {
       return this.#telemetryProcessors[keyString];
     }
 
     const telemetryProcessor = (newTelemetry) => {
@@ -240,7 +240,7 @@
   }
 
   #telemetryProcessor = (newTelemetry, keyString) => {
     this.emit('underlyingTelemetryUpdated', { [keyString]: newTelemetry });
   };
 
   clearData(telemetryLoadedPromise) {