[opentelemetry-collector] Add spanmetrics processor preset #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allex1
approved these changes
Oct 26, 2022
c55ae1b
to
8d8539d
Compare
povilasv
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Nice :) Maybe we should add some section in README like https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-collector#configuration-for-kubernetes-container-logs ?
|
I thought we need an additional pipeline for the span metrics but it doesn't seem like required, so this preset doesn't provide a lot of help. The processor can be easily added in the |
|
@dmitryax I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a spanmetrics processor preset. Allows configuring the name of which exporter is used.
As it relates to #456 IDK if it will simplify the demo's values.yaml since the preset will need configured and the collector's config will still need to create the prometheus exporter and add it to the metrics pipeline, but its always nice to use presets where they exist.