functions/constant Minor tweak to "errors" section#1565
Merged
Crell merged 1 commit intophp:masterfrom Jun 27, 2022
Merged
Conversation
Member
|
I'm not strictly against changing this, but we should have some style guideline about those error sections. Otherwise we're risking to change the syntax over and over again, what would be particularly annoying for translators. |
Contributor
|
The current text is just flat out incorrect because of the comma. There should either be no comma, or this change that reverses the clause order. Either would work. Since this one is here, I'm good with it for now. |
tiffany-taylor
pushed a commit
to tiffany-taylor/doc-en
that referenced
this pull request
Jan 16, 2023
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.php.net/manual/en/function.constant.php
This updates the text from:
to:
The existing text is more difficult to read as it puts the condition behind the result. If the existing text is preferred, I'd remove the comma.