Skip to content

Fix concurrency issue about const apiUrl#3371

Merged
PromoFaux merged 1 commit intodevelopmentfrom
fix/apiUrl
Apr 2, 2025
Merged

Fix concurrency issue about const apiUrl#3371
PromoFaux merged 1 commit intodevelopmentfrom
fix/apiUrl

Conversation

@DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 31, 2025

What does this implement/fix?

Always use document.body.dataset.apiurl instead of the intermediate constant apiUrl


Related issue or feature (if applicable): Fixes #3361 Fixes #3369

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER added the Bugfix label Mar 31, 2025
@DL6ER DL6ER requested a review from a team March 31, 2025 19:40
@DL6ER DL6ER force-pushed the fix/apiUrl branch 2 times, most recently from c0c04ce to 251fd4d Compare March 31, 2025 19:52
…onst apiUrl

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Copy link
Member Author

DL6ER commented Mar 31, 2025

Sorry for the many force-pushes but I cannot run xo locally and I don't know why. It stays spinning the CPU at 100% for more than ten minutes until I manually kill it.

@XhmikosR
Copy link
Contributor

XhmikosR commented Apr 1, 2025

Try removing your local node_modules folder and doing npm ci again. Also, check if you have the latest Node.js LTS on your system and maybe do npm cache clean -fg to clear the global npm cache.

@PromoFaux PromoFaux merged commit 1e8baeb into development Apr 2, 2025
11 checks passed
@PromoFaux PromoFaux deleted the fix/apiUrl branch April 2, 2025 17:09
@PromoFaux PromoFaux mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants