Fix concurrency issue about const apiUrl#3371
Merged
PromoFaux merged 1 commit intodevelopmentfrom Apr 2, 2025
Merged
Conversation
c0c04ce to
251fd4d
Compare
…onst apiUrl Signed-off-by: DL6ER <dl6er@dl6er.de>
Member
Author
|
Sorry for the many force-pushes but I cannot run |
XhmikosR
approved these changes
Apr 1, 2025
Contributor
|
Try removing your local |
PromoFaux
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Always use
document.body.dataset.apiurlinstead of the intermediate constantapiUrlRelated issue or feature (if applicable): Fixes #3361 Fixes #3369
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.