3254 sprite group support source rect#3256
Closed
JovialKnoll wants to merge 7 commits intopygame-community:mainfrom
JovialKnoll:3254-sprite-group-support-source_rect
Closed
3254 sprite group support source rect#3256JovialKnoll wants to merge 7 commits intopygame-community:mainfrom JovialKnoll:3254-sprite-group-support-source_rect
JovialKnoll wants to merge 7 commits intopygame-community:mainfrom
JovialKnoll:3254-sprite-group-support-source_rect
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first stab at the changes I described in #3254
If it would be better to not move the
source_rectintoSpriteI'd be happy to take that out and just check for source_rect in the draw functions with something likegetattr(spr, 'source_rect', None).I'm sure there might be some tests or something that I've missed but I thought it would be better to get a go-ahead on this before I do more.