Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop circleci, use gh actions for arm manylinux #3293

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ankith26
Copy link
Member

https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

By removing circleci we are reducing our maintenance burden, and now have one unified config to maintain for manylinux instead of 2.

@ankith26 ankith26 requested a review from a team as a code owner January 17, 2025 03:19
@ankith26 ankith26 force-pushed the ankith26-drop-circleci branch from 3f5d322 to 3433bde Compare January 17, 2025 04:14
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the size and checked the same wheels generated, looks good to me.

The arm runners are a public preview though so they could go away in the future.

@ankith26
Copy link
Member Author

We can always switch back to circleci easily if the need arises in the future

@MyreMylar
Copy link
Member

Looks like CircleCI still tried to run on this PR.

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ankith26 ankith26 added this to the 2.5.3 milestone Jan 17, 2025
@ankith26
Copy link
Member Author

I have disabled CircleCI from the web UI now, so it shouldn't try to build and fail after this PR is merged

@ankith26 ankith26 merged commit 565cae6 into main Jan 17, 2025
24 of 25 checks passed
@ankith26 ankith26 deleted the ankith26-drop-circleci branch January 17, 2025 18:21
@Starbuck5 Starbuck5 added the CI Issue with the Continuous Integration (CI), the actions/bots that test things label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants