Skip to content

fix job.status() in tests and CircleCI caching #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drakejwong merged 6 commits into from
Aug 16, 2022
Merged

fix job.status() in tests and CircleCI caching #347

drakejwong merged 6 commits into from
Aug 16, 2022

Conversation

@drakejwong
Copy link
Contributor

@drakejwong drakejwong commented Aug 15, 2022 •
edited
Loading

  • Fix AsyncJob status payload keys causing test failures
  • Fix AsyncJob export test
  • Fix page_size for .items_and_annotatation_generator()
  • Change to simple dependency install step to fix CircleCI caching failures

@drakejwong drakejwong requested review from gatli and shiftsayan August 15, 2022 17:57
@drakejwong drakejwong changed the title Fix job.status() for tests and CircleCI caching fix job.status() in tests and CircleCI caching Aug 15, 2022
@drakejwong drakejwong mentioned this pull request Aug 15, 2022
Merged
@drakejwong
Copy link
Contributor Author

drakejwong commented Aug 15, 2022

FYI: update_autotag test will fail until https://github.com/scaleapi/scaleapi/pull/44834 lands, so I will force-merge assuming all other tests pass

@drakejwong drakejwong merged commit 95681af into master Aug 16, 2022
@drakejwong drakejwong deleted the drake-fix-tests branch August 16, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatli gatli Awaiting requested review from gatli

1 more reviewer

@shiftsayan shiftsayan shiftsayan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drakejwong @shiftsayan