8414 add records selection context inside the command menu #8610
+763
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be awesome! Some feedbacks: Dark Mode issue
Need two escape to remove the selectionWhen focus is on "Type anything" first escape remove the focus on the input, second escape remove the selection Removing the selection in breadcrumb should remove the selection on table/kanbansIf i press ⌫ or escape, should also deselect the record on the left Header sizeShould be 56px to match. Check all the header paddings
Chip should be 32px heighput the border inside or make the chip 30px if the border are outside
Delete doesn't workCleanShot.2024-11-20.at.18.51.22.mp4Icon identifiersPeople icon identifiers should be rounded
Tasks & Notes should use their colored icon image identifiers
Empty state in wrongly aligned
|
| display: flex; | ||
| `; | ||
|
|
||
| const CommandMenuContextRecordChipAvatars = ({ |
There was a problem hiding this comment.
1 type per file, 1 component per file
| @@ -11,10 +11,10 @@ export const MainContextStoreComponentInstanceIdSetterEffect = () => { | |||
| const context = useContext(ContextStoreComponentInstanceContext); | |||
|
|
|||
| useEffect(() => { | |||
| setMainContextStoreComponentInstanceId(context?.instanceId ?? null); | |||
| setMainContextStoreComponentInstanceId(context?.instanceId ?? 'app'); | |||
| export const useContextStoreCurrentObjectMetadataIdOrThrow = ( | ||
| instanceId?: string, | ||
| ) => { | ||
| const contextStoreCurrentObjectMetadataIdComponent = |
| import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords'; | ||
| import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2'; | ||
|
|
||
| export const useContextStoreSelectedRecords = ({ |
There was a problem hiding this comment.
useFindManyRecordSelectedInContextStore
charlesBochet
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8414
Enregistrement.de.l.ecran.2024-11-20.a.16.27.44.mov