Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8414 add records selection context inside the command menu #8610

Merged
merged 17 commits into from
Nov 21, 2024
Merged

8414 add records selection context inside the command menu #8610

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0d54ca4
extract the top bar in a new component
bosiraphael Nov 19, 2024
2a0f5fb
create context chip for command menu
bosiraphael Nov 19, 2024
efdb661
Add seleted records avatars
bosiraphael Nov 19, 2024
cc460d5
refactoring, bug fixes and create CommandMenuCommandsEffect
bosiraphael Nov 20, 2024
4ca34a8
reorder records in chips
bosiraphael Nov 20, 2024
e5b9fb2
fix background color
bosiraphael Nov 20, 2024
1e3032a
fixes
bosiraphael Nov 20, 2024
e6195c4
fix hotkey scopes
bosiraphael Nov 20, 2024
e1415b6
Merge branch 'main' into 8414-add-records-selection-context-inside-th…
bosiraphael Nov 20, 2024
8c05830
show objectRecordIdentifier name when only one record is selected
bosiraphael Nov 20, 2024
1ba43bb
improve command menu actions ordering
bosiraphael Nov 20, 2024
b73c806
fix stories
bosiraphael Nov 20, 2024
1b2302e
fix tests
bosiraphael Nov 20, 2024
4053c56
fix text color in dark mode
bosiraphael Nov 21, 2024
6be2b15
fix command menu height and chip sizing
bosiraphael Nov 21, 2024
32fb2da
use standard object icon if available in chip
bosiraphael Nov 21, 2024
281e5ec
fix delete records
bosiraphael Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reorder records in chips
  • Loading branch information
@bosiraphael
bosiraphael committed Nov 20, 2024
commit 4ca34a8615160a59fe7fe9b692ae01600328130f
1 change: 1 addition & 0 deletions packages/twenty-front/src/modules/command-menu/components/CommandMenuContextRecordChip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export const CommandMenuContextRecordChip = () => {

const { records, loading, totalCount } = useContextStoreSelectedRecords(
mainContextStoreComponentInstanceId,
3,
);

if (loading || !totalCount) {
Expand Down
2 changes: 1 addition & 1 deletion packages/twenty-front/src/modules/context-store/hooks/useContextStoreSelectedRecords.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const useContextStoreSelectedRecords = (
filter: queryFilter,
orderBy: [
{
createdAt: 'DescNullsFirst',
position: 'AscNullsFirst',
},
],
skip:
Expand Down